Skip to content

Change strings::like() pattern parameter from string_scalar to string_view #20428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Nov 12, 2025
Merged

Change strings::like() pattern parameter from string_scalar to string_view #20428

merged 18 commits into from
Nov 12, 2025

Conversation

@davidwendt
Copy link
Contributor

@davidwendt davidwendt commented Oct 30, 2025

Description

Deprecates the cudf::strings::like API that accepts the pattern and escape character as string_scalar types and replaces it with one which accepts std::string_view instead.

cudf::strings::like(
  cudf::strings_column_view const& input,
  cudf::string_scalar const& pattern,  ==>  std::string_view
  cudf::string_scalar const& escape_character, ==> std::string_view
  rmm::cuda_stream_view stream,
  rmm::device_async_resource_ref mr)

This is to enable future performance optimizations where the pattern is preprocessed on the host and not needed in device memory.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@davidwendt davidwendt self-assigned this Oct 30, 2025
@davidwendt davidwendt added 2 - In Progress Currently a work in progress libcudf Affects libcudf (C++/CUDA) code. improvement Improvement / enhancement to an existing function non-breaking Non-breaking change labels Oct 30, 2025
@copy-pr-bot
Copy link

copy-pr-bot bot commented Oct 30, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@github-actions github-actions bot added Python Affects Python cuDF API. pylibcudf Issues specific to the pylibcudf package labels Oct 30, 2025
@GPUtester GPUtester moved this to In Progress in cuDF Python Oct 30, 2025
@davidwendt
Copy link
Contributor Author

davidwendt commented Oct 30, 2025

/ok to test

@davidwendt
Copy link
Contributor Author

davidwendt commented Oct 30, 2025

/ok to test

@davidwendt
Copy link
Contributor Author

davidwendt commented Oct 30, 2025

/ok to test

@davidwendt davidwendt marked this pull request as ready for review October 31, 2025 19:14
@davidwendt davidwendt requested review from a team as code owners October 31, 2025 19:14
mroeschke
mroeschke approved these changes Oct 31, 2025
View reviewed changes
Copy link
Contributor

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python changes LGTM

@davidwendt davidwendt added 3 - Ready for Review Ready for review by team and removed 2 - In Progress Currently a work in progress labels Oct 31, 2025
@davidwendt davidwendt moved this to Burndown in libcudf Nov 6, 2025
bdice
bdice requested changes Nov 7, 2025
View reviewed changes
karthikeyann
karthikeyann reviewed Nov 10, 2025
View reviewed changes
wence-
wence- requested changes Nov 10, 2025
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a stream sync in the cython bindings I think.

@davidwendt davidwendt requested a review from wence- November 12, 2025 13:12
@davidwendt davidwendt added breaking Breaking change and removed non-breaking Non-breaking change labels Nov 12, 2025
wence-
wence- approved these changes Nov 12, 2025
View reviewed changes
Copy link
Contributor

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving python, thanks!

@davidwendt
Copy link
Contributor Author

davidwendt commented Nov 12, 2025

/merge

@rapids-bot rapids-bot bot merged commit 85505aa into rapidsai:main Nov 12, 2025
140 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in cuDF Python Nov 12, 2025
@davidwendt davidwendt deleted the string-like-pattern branch November 12, 2025 23:44
@mhaseeb123 mhaseeb123 moved this from Burndown to Landed in libcudf Nov 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wence- wence- wence- approved these changes

@vyasr vyasr vyasr approved these changes

@bdice bdice bdice approved these changes

@karthikeyann karthikeyann karthikeyann approved these changes

@mroeschke mroeschke mroeschke approved these changes

@rjzamora rjzamora Awaiting requested review from rjzamora rjzamora is a code owner automatically assigned from rapidsai/cudf-python-codeowners

@devavret devavret Awaiting requested review from devavret devavret is a code owner automatically assigned from rapidsai/cudf-cpp-codeowners

Assignees

@davidwendt davidwendt

Labels

3 - Ready for Review Ready for review by team breaking Breaking change improvement Improvement / enhancement to an existing function libcudf Affects libcudf (C++/CUDA) code. pylibcudf Issues specific to the pylibcudf package Python Affects Python cuDF API.

Projects

cuDF Python
Status: Done
libcudf
Status: Landed

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@davidwendt @wence- @vyasr @bdice @karthikeyann @mroeschke